Repository navigation
Add role-bound GitHub App execution and candidate reconciliation - #2376
Merged
zy95-12 merged 1 commit intoNov 4, 2026
Conversation
Implement ThinkFlowLab#2365 on the delivery branch using original credential providers, execution fences and durable Effects. Preserve SDK commit and PR identity, require actual independent App Reviews, and document opt-in configuration and pending live App acceptance.
zy95-12
marked this pull request as ready for review
November 4, 2026 09:32
zy95-12
merged commit Nov 4, 2026
d39e70b
into
ThinkFlowLab:delivery/ai-centric-development-service
11 of 13 checks passed
Open
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Codex
Refs #2365. Target:
delivery/ai-centric-development-service.Opt-in role App bindings let SDK/native Dev commit/push/update the original Draft PR and Reviewer submit an actual exact-SHA Review with a different App. Dedicated short-lived helpers reuse the existing installation provider and worker/claim/resource fences; no Owner fallback or generic Token export. Original candidate Effects adopt the real SDK SHA/PR and reconcile interrupted writeback. Host tests, signed forge PASS, selected host App merge and Chief acceptance remain separate.
Includes memory/dated decision, owned architecture, role conventions, README/operator guide, OpenAPI, generated patches and regression tests. No Control Plane/UI, live task/configuration/credential or deployment changes.
Validation at
d0f2b844c01a0fcced4fdbf92f11d36115fee271:TZ=UTC setpriv --bounding-set=-dac_override,-dac_read_search npm run verifypassed: 4,930 tests across all suite groups, including core 3,122 and all 8 actual disposable DSH runtime cases. Node 24 basic CItests-okis green at this exact head.Real GitHub App push/PR/Review/check/merge acceptance is pending explicitly authorized installed Dev/Reviewer Apps and a test repository. Keep #2365 open; do not substitute personal gh activity for App evidence. Installation Tokens are not branch-scoped; existing branch protection/checks still apply.
Pairing self-review covers correctness, security and conventions; no unresolved implementation blockers or independent forge PASS claimed. Merge scope follows the Owner's existing delivery-branch/basic-CI instruction.
Delivery-only gate scope: the Owner previously waived independent signed Review/enqueue checkpoints for this non-main branch.
enqueue-guardreports missing Verifier; no PASS is fabricated. Target branch rules query returns no applicable rules,tests-okis green and PR is mergeable; no admin/rules/check bypass is used.